opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

daily-email: add 2023-08-31

Browse source 
Code review discourages small refactorings
This commit is contained in:
Oliver Davies 2023-09-04 21:30:23 +01:00
parent 1e3ece300a
commit d7e80b3192
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/content/daily-email/2023-08-31.md Normal file
View file

@ -0,0 +1,16 @@
---
title: >
Code review discourages small refactorings
pubDate: 2023-08-31
permalink: >
archive/2023/08/31/code-review-discourages-small-refactorings
tags:
- code-reviews
- trunk-based-development
---
If, for every change to a codebase, you need to create a topic branch, create a pull or merge request, and wait for it to be reviewed and approved - which can take days, weeks or longer - does that discourage you from making small changes?
If you spotted some unused commented-out code whilst working in a file and went to remove it or a variable that could have a better name, would you change it?
Alternatively, if you could make the change and know from a CI pipeline within a few minutes that everything still worked, would you be more likely to make the change and improve the code for yourself and the next person to work on it?