From d7e80b3192ed812550af9454abf48d80e7b4fa0f Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Mon, 4 Sep 2023 21:30:23 +0100 Subject: [PATCH] daily-email: add 2023-08-31 Code review discourages small refactorings --- src/content/daily-email/2023-08-31.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 src/content/daily-email/2023-08-31.md diff --git a/src/content/daily-email/2023-08-31.md b/src/content/daily-email/2023-08-31.md new file mode 100644 index 00000000..9aca2822 --- /dev/null +++ b/src/content/daily-email/2023-08-31.md @@ -0,0 +1,16 @@ +--- +title: > + Code review discourages small refactorings +pubDate: 2023-08-31 +permalink: > + archive/2023/08/31/code-review-discourages-small-refactorings +tags: + - code-reviews + - trunk-based-development +--- + +If, for every change to a codebase, you need to create a topic branch, create a pull or merge request, and wait for it to be reviewed and approved - which can take days, weeks or longer - does that discourage you from making small changes? + +If you spotted some unused commented-out code whilst working in a file and went to remove it or a variable that could have a better name, would you change it? + +Alternatively, if you could make the change and know from a CI pipeline within a few minutes that everything still worked, would you be more likely to make the change and improve the code for yourself and the next person to work on it?