101 lines
3.4 KiB
YAML
101 lines
3.4 KiB
YAML
uuid:
|
|
- value: b6fd9a07-2647-4b83-9ca7-2d3a5668865c
|
|
langcode:
|
|
- value: en
|
|
type:
|
|
- target_id: daily_email
|
|
target_type: node_type
|
|
target_uuid: 8bde1f2f-eef9-4f2d-ae9c-96921f8193d7
|
|
revision_timestamp:
|
|
- value: '2025-05-11T09:00:30+00:00'
|
|
revision_uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
revision_log: { }
|
|
status:
|
|
- value: true
|
|
uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
title:
|
|
- value: |
|
|
92 changed files with 885 additions and 156 deletions
|
|
created:
|
|
- value: '2023-09-29T00:00:00+00:00'
|
|
changed:
|
|
- value: '2025-05-11T09:00:30+00:00'
|
|
promote:
|
|
- value: false
|
|
sticky:
|
|
- value: false
|
|
default_langcode:
|
|
- value: true
|
|
revision_translation_affected:
|
|
- value: true
|
|
path:
|
|
- alias: /daily/2023/09/29/92-changed-files-with-885-additions-and-156-deletions
|
|
langcode: en
|
|
body:
|
|
- value: |
|
|
<p>Today, I refactored some code on a client's Drupal project I've been working on.</p>
|
|
|
|
<p>This is what the commit says:</p>
|
|
|
|
<blockquote>
|
|
<p>Showing 92 changed files with 885 additions and 156 deletions</p>
|
|
</blockquote>
|
|
|
|
<p>So, it's not a small refactor.</p>
|
|
|
|
<p>As I worked on the custom modules needed for the site, I noticed that some common functionality was spread over multiple modules. This refactor moved that functionality into its own module, which is now a dependency of the others.</p>
|
|
|
|
<p>The code is better, and the responsibilities of the modules are clearer.</p>
|
|
|
|
<p>Whilst a large amount of those additions are adding test modules with test configuration, it's not a small refactor.</p>
|
|
|
|
<h2 id="here%27s-the-thing">Here's the thing</h2>
|
|
|
|
<p>This is what it says at the bottom of the CI pipeline output:</p>
|
|
|
|
<blockquote>
|
|
<p>OK (79 tests, 565 assertions)</p>
|
|
</blockquote>
|
|
|
|
<p>This is the same number of passing tests and assertions I had before I started the refactor, so I know the functionality still works.</p>
|
|
|
|
<p>If I didn't have those tests, I wouldn't have done the refactor.</p>
|
|
|
|
|
|
format: full_html
|
|
processed: |
|
|
<p>Today, I refactored some code on a client's Drupal project I've been working on.</p>
|
|
|
|
<p>This is what the commit says:</p>
|
|
|
|
<blockquote>
|
|
<p>Showing 92 changed files with 885 additions and 156 deletions</p>
|
|
</blockquote>
|
|
|
|
<p>So, it's not a small refactor.</p>
|
|
|
|
<p>As I worked on the custom modules needed for the site, I noticed that some common functionality was spread over multiple modules. This refactor moved that functionality into its own module, which is now a dependency of the others.</p>
|
|
|
|
<p>The code is better, and the responsibilities of the modules are clearer.</p>
|
|
|
|
<p>Whilst a large amount of those additions are adding test modules with test configuration, it's not a small refactor.</p>
|
|
|
|
<h2 id="here%27s-the-thing">Here's the thing</h2>
|
|
|
|
<p>This is what it says at the bottom of the CI pipeline output:</p>
|
|
|
|
<blockquote>
|
|
<p>OK (79 tests, 565 assertions)</p>
|
|
</blockquote>
|
|
|
|
<p>This is the same number of passing tests and assertions I had before I started the refactor, so I know the functionality still works.</p>
|
|
|
|
<p>If I didn't have those tests, I wouldn't have done the refactor.</p>
|
|
|
|
|
|
summary: null
|
|
field_daily_email_cta: { }
|