64 lines
2.4 KiB
YAML
64 lines
2.4 KiB
YAML
uuid:
|
|
- value: 17a436ab-84f0-4c0a-9305-b04a9e1883ee
|
|
langcode:
|
|
- value: en
|
|
type:
|
|
- target_id: daily_email
|
|
target_type: node_type
|
|
target_uuid: 8bde1f2f-eef9-4f2d-ae9c-96921f8193d7
|
|
revision_timestamp:
|
|
- value: '2025-05-11T09:00:05+00:00'
|
|
revision_uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
revision_log: { }
|
|
status:
|
|
- value: true
|
|
uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
title:
|
|
- value: 'Code reviews are about the code, not code style'
|
|
created:
|
|
- value: '2024-10-30T00:00:00+00:00'
|
|
changed:
|
|
- value: '2025-05-11T09:00:05+00:00'
|
|
promote:
|
|
- value: false
|
|
sticky:
|
|
- value: false
|
|
default_langcode:
|
|
- value: true
|
|
revision_translation_affected:
|
|
- value: true
|
|
path:
|
|
- alias: /daily/2024/10/30/code-reviews-are-about-the-code-not-code-style
|
|
langcode: en
|
|
body:
|
|
- value: |
|
|
<p>If you do code reviews, they should be about reviewing the code and not about the style of the code.</p>
|
|
|
|
<p>There shouldn't be comments about whether tabs or spaces are used, how many spaces are on each line, where the braces are, or whether there should be semicolons.</p>
|
|
|
|
<p>A code style should be defined upfront and checking code against it can be done automatically with tools such as phpcs or Prettier.</p>
|
|
|
|
<p>You don't need to wait for a human to review the code style - automated tools can be run locally or in a CI pipeline and provide feedback much faster.</p>
|
|
|
|
<p>And if people aren't reviewing the code style, they can focus on reviewing the code itself.</p>
|
|
|
|
|
|
format: full_html
|
|
processed: |
|
|
<p>If you do code reviews, they should be about reviewing the code and not about the style of the code.</p>
|
|
|
|
<p>There shouldn't be comments about whether tabs or spaces are used, how many spaces are on each line, where the braces are, or whether there should be semicolons.</p>
|
|
|
|
<p>A code style should be defined upfront and checking code against it can be done automatically with tools such as phpcs or Prettier.</p>
|
|
|
|
<p>You don't need to wait for a human to review the code style - automated tools can be run locally or in a CI pipeline and provide feedback much faster.</p>
|
|
|
|
<p>And if people aren't reviewing the code style, they can focus on reviewing the code itself.</p>
|
|
|
|
|
|
summary: null
|
|
field_daily_email_cta: { }
|