73 lines
3.1 KiB
YAML
73 lines
3.1 KiB
YAML
uuid:
|
|
- value: 050525d7-3275-486e-8f0e-9548aa81a156
|
|
langcode:
|
|
- value: en
|
|
type:
|
|
- target_id: daily_email
|
|
target_type: node_type
|
|
target_uuid: 8bde1f2f-eef9-4f2d-ae9c-96921f8193d7
|
|
revision_timestamp:
|
|
- value: '2025-05-11T09:00:34+00:00'
|
|
revision_uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
revision_log: { }
|
|
status:
|
|
- value: true
|
|
uid:
|
|
- target_type: user
|
|
target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849
|
|
title:
|
|
- value: |
|
|
Pull requests are great for open-source, but not for teams
|
|
created:
|
|
- value: '2023-08-27T00:00:00+00:00'
|
|
changed:
|
|
- value: '2025-05-11T09:00:34+00:00'
|
|
promote:
|
|
- value: false
|
|
sticky:
|
|
- value: false
|
|
default_langcode:
|
|
- value: true
|
|
revision_translation_affected:
|
|
- value: true
|
|
path:
|
|
- alias: /daily/2023/08/27/pull-requests-are-great-for-open-source
|
|
langcode: en
|
|
body:
|
|
- value: |
|
|
<p>Code review with pull and merge requests is great for open-source but not for development teams or soloists.</p>
|
|
|
|
<p>On an open-source project, the code changes are most likely being submitted by someone you don't know and don't work with regularly, so having a step to review the code prior to merging it and decide if you want to take on the responsibility of maintaining it is a big decision.</p>
|
|
|
|
<p>On a development team, you work closely with the person submitting the change request and you have a shared responsibility and ownership of the code being added. The person isn't going to submit their change and not be seen again.</p>
|
|
|
|
<p>It takes time for code to be reviewed, which means it takes longer for the change to be released to users.</p>
|
|
|
|
<p>If you're a soloist, are you going to submit a request for you to review your own code?</p>
|
|
|
|
<p>If you don't need to do code review on your team, do you need to create feature or topic branches?</p>
|
|
|
|
<p>I'd suggest sticking to one canonical branch and doing trunk-based development instead.</p>
|
|
|
|
|
|
format: full_html
|
|
processed: |
|
|
<p>Code review with pull and merge requests is great for open-source but not for development teams or soloists.</p>
|
|
|
|
<p>On an open-source project, the code changes are most likely being submitted by someone you don't know and don't work with regularly, so having a step to review the code prior to merging it and decide if you want to take on the responsibility of maintaining it is a big decision.</p>
|
|
|
|
<p>On a development team, you work closely with the person submitting the change request and you have a shared responsibility and ownership of the code being added. The person isn't going to submit their change and not be seen again.</p>
|
|
|
|
<p>It takes time for code to be reviewed, which means it takes longer for the change to be released to users.</p>
|
|
|
|
<p>If you're a soloist, are you going to submit a request for you to review your own code?</p>
|
|
|
|
<p>If you don't need to do code review on your team, do you need to create feature or topic branches?</p>
|
|
|
|
<p>I'd suggest sticking to one canonical branch and doing trunk-based development instead.</p>
|
|
|
|
|
|
summary: null
|
|
field_daily_email_cta: { }
|