uuid: - value: 9d63cfe9-dd20-4e58-955f-bd42a5026c8a langcode: - value: en type: - target_id: daily_email target_type: node_type target_uuid: 8bde1f2f-eef9-4f2d-ae9c-96921f8193d7 revision_timestamp: - value: '2025-05-11T09:00:00+00:00' revision_uid: - target_type: user target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849 revision_log: { } status: - value: true uid: - target_type: user target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849 title: - value: "Don't repeat yourself" created: - value: '2025-03-26T00:00:00+00:00' changed: - value: '2025-05-11T09:00:00+00:00' promote: - value: false sticky: - value: false default_langcode: - value: true revision_translation_affected: - value: true path: - alias: /daily/2025/03/26/repeat langcode: en body: - value: |

When most people think of "Don't repeat yourself" or DRY, they probably think about not duplicating logic in code.

If you've written some functionality once, you should avoid writing it again.

I was recently browsing the code for an open source package and saw this:

/**
       * Flush everything.
       */
      public function flush(): void;

      /**
       * Sets the formatter.
       */
      public function setFormatter(FormatterInterface $formatter): void;

      /**
       * Gets the formatter.
       */
      public function getFormatter(): FormatterInterface;
      

This is another instance of repetition.

The docblocks are just repeating what the code already tells me.

I can understand from the method names what each function does, and I can see what parameters they have and their types.

I can see if each method returns anything and, if so, what type it returns - e.g. getFormatter returns a FormatterInterface.

I think these docblocks aren't needed and in my projects, would suggest they be removed.

Unless they're adding more information, such as PHPStan PHPDoc types, there's no need to repeat what the code already says.

format: full_html processed: |

When most people think of "Don't repeat yourself" or DRY, they probably think about not duplicating logic in code.

If you've written some functionality once, you should avoid writing it again.

I was recently browsing the code for an open source package and saw this:

/**
       * Flush everything.
       */
      public function flush(): void;

      /**
       * Sets the formatter.
       */
      public function setFormatter(FormatterInterface $formatter): void;

      /**
       * Gets the formatter.
       */
      public function getFormatter(): FormatterInterface;
      

This is another instance of repetition.

The docblocks are just repeating what the code already tells me.

I can understand from the method names what each function does, and I can see what parameters they have and their types.

I can see if each method returns anything and, if so, what type it returns - e.g. getFormatter returns a FormatterInterface.

I think these docblocks aren't needed and in my projects, would suggest they be removed.

Unless they're adding more information, such as PHPStan PHPDoc types, there's no need to repeat what the code already says.

summary: null field_daily_email_cta: { }