uuid: - value: 7f09e435-16da-4a6c-bffa-d297282760e9 langcode: - value: en type: - target_id: daily_email target_type: node_type target_uuid: 8bde1f2f-eef9-4f2d-ae9c-96921f8193d7 revision_timestamp: - value: '2025-06-15T15:10:28+00:00' revision_uid: - target_type: user target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849 revision_log: { } status: - value: true uid: - target_type: user target_uuid: b8966985-d4b2-42a7-a319-2e94ccfbb849 title: - value: 'Do code reviews prevent refactoring?' created: - value: '2025-06-14T14:58:57+00:00' changed: - value: '2025-06-15T15:10:28+00:00' promote: - value: false sticky: - value: false default_langcode: - value: true revision_translation_affected: - value: true path: - alias: /daily/2025/06/14/do-code-reviews-prevent-refactoring langcode: en body: - value: |- Does having a strict code review process prevent or discourage refactoring? If I want to make a very small refactor, like renaming a variable, am I likely to do that if I need to make a feature branch, create a merge request, and wait for multiple reviews from team members? What if it takes a day or more for someone to review it? Is it worth a reviewer's time to review a refactoring that could only be a single line of changed code? Alternatively, what if you were doing trunk-based development and/or continuous integration? What if you could make the small change, push it and have a CI pipeline automatically review it? The whole process could be completed in minutes. No long wait for manual code review and once you finish that refactoring, [you may find another](/daily/2025/06/13/refactorings-should-be-small). format: markdown processed: |
Does having a strict code review process prevent or discourage refactoring?
If I want to make a very small refactor, like renaming a variable, am I likely to do that if I need to make a feature branch, create a merge request, and wait for multiple reviews from team members?
What if it takes a day or more for someone to review it?
Is it worth a reviewer's time to review a refactoring that could only be a single line of changed code?
Alternatively, what if you were doing trunk-based development and/or continuous integration?
What if you could make the small change, push it and have a CI pipeline automatically review it?
The whole process could be completed in minutes.
No long wait for manual code review and once you finish that refactoring, you may find another.
summary: '' field_daily_email_cta: - target_type: node target_uuid: 3074e1e9-c691-4f73-a71c-cfe5920f884e