opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues 1 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Return Collections rather than arrays

Browse source
This commit is contained in:
Oliver Davies 2019-09-27 01:51:32 +01:00
parent 3ec494d693
commit eac0cba9ae
3 changed files with 16 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Talks/tests/RetrievingTalksTest.php
View file

@ -95,7 +95,7 @@ class RetrievingTalksTest extends TestCase
$filtered = $this->extension->filterPastTalks($talks);
$this->assertCount(1, $filtered);
$this->assertSame($pastTalk, $filtered[0]);
$this->assertSame($pastTalk, $filtered->first());
}
/** @test */
@ -125,8 +125,8 @@ class RetrievingTalksTest extends TestCase
$talks = $this->extension->getTalks([$pastTalk, $todayTalk, $futureTalk]);
$filtered = $this->extension->filterUpcomingTalks($talks);
$this->assertCount(2, $filtered);
$this->assertSame([$todayTalk, $futureTalk], $filtered);
$this->assertSame(2, $filtered->count());
$this->assertSame([$todayTalk, $futureTalk], $filtered->toArray());
}
/** @test */
@ -166,9 +166,7 @@ class RetrievingTalksTest extends TestCase
$talks = collect([$talkA, $talkB]);
tap($this->extension->getAllEvents($talks), function (array $events) {
$events = collect($events);
tap($this->extension->getAllEvents($talks), function (Collection $events) {
$this->assertCount(3, $events);
$this->assertSame(