opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues 1 Pull requests Projects 1 Releases Packages Wiki Activity Actions

build(deps): remove discoverable_entity_bundle_classes

Browse source 
As this module is no longer supported, remove it from the codebase and
update all references to it within the custom code - instead manually
wrapping nodes with the `Post` or `Talk` class, or returning it from a
Repository.

Fixes: #465
This commit is contained in:
Oliver Davies 2021-12-17 15:16:52 +00:00
parent 41e13fe078
commit cae2091436
24 changed files with 214 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

3
web/modules/custom/blog/tests/src/Kernel/Entity/Node/PostTest.php
View file

@ -16,9 +16,6 @@ final class PostTest extends EntityKernelTestBase {
'link',
'taxonomy',
// Contrib.
'discoverable_entity_bundle_classes',
// Custom.
'opdavies_blog',
'opdavies_blog_test',

1
web/modules/custom/blog/tests/src/Kernel/PostTestBase.php
View file

@ -18,7 +18,6 @@ abstract class PostTestBase extends EntityKernelTestBase {
'link',
// Contrib.
'discoverable_entity_bundle_classes',
'hook_event_dispatcher',
'core_event_dispatcher',

8
web/modules/custom/blog/tests/src/Kernel/PushToSocialMediaTest.php
View file

@ -6,8 +6,9 @@ namespace Drupal\Tests\opdavies_blog\Kernel;
use Drupal\Core\Queue\QueueInterface;
use Drupal\KernelTests\Core\Entity\EntityKernelTestBase;
use Drupal\opdavies_blog\Entity\Node\Post;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\node\NodeInterface;
use Drupal\opdavies_blog\Entity\Node\Post;
final class PushToSocialMediaTest extends EntityKernelTestBase {
@ -20,7 +21,6 @@ final class PushToSocialMediaTest extends EntityKernelTestBase {
'link',
// Contrib.
'discoverable_entity_bundle_classes',
'hook_event_dispatcher',
'core_event_dispatcher',
@ -48,8 +48,8 @@ final class PushToSocialMediaTest extends EntityKernelTestBase {
$post = $item->data['post'];
$this->assertNotNull($post);
$this->assertInstanceOf(Post::class, $post);
$this->assertSame('1', $post->id());
$this->assertInstanceOf(NodeInterface::class, $post);
$this->assertSame('post', $post->bundle());
$this->assertSame('Ignoring PHPCS sniffs within PHPUnit tests', $post->getTitle());
}

5
web/modules/custom/blog/tests/src/Kernel/ReorderBlogTagsTest.php
View file

@ -5,6 +5,7 @@
namespace Drupal\Tests\opdavies_blog\Kernel;
use Drupal\node\Entity\Node;
use Drupal\node\NodeInterface;
use Drupal\opdavies_blog\Entity\Node\Post;
use Drupal\taxonomy\Entity\Vocabulary;
use Drupal\taxonomy\TermInterface;
@ -26,8 +27,8 @@ final class ReorderBlogTagsTest extends PostTestBase {
Post::FIELD_TAGS => [3, 1, 2],
]);
/** @var Post $post */
$post = Node::load($post->id());
$node = Node::load($post->id());
$post = Post::createFromNode($node);
$this->assertSame(
['Drupal', 'PHP', 'Symfony'],