Refactor

modules/opd_daily_emails/src/Action/AddRandomCtaToDailyEmail.php

@@ -15,18 +15,7 @@ readonly final class AddRandomCtaToDailyEmail {
   }
 
   public function __invoke(DailyEmail $email): void {
-    if (!$email->isNew()) {
+    if (!$this->shouldUpdate($email)) {
-      return;
-    }
-
-    if ($email->get('field_daily_email_cta')->getValue() !== []) {
-      return;
-    }
-
-    $body = $email->get('body')->value;
-    assert(is_string($body));
-
-    if (str_contains(haystack: $body, needle: 'P.S.')) {
       return;
     }
 
@@ -51,4 +40,23 @@ readonly final class AddRandomCtaToDailyEmail {
     return Ctas::fromNodes($ctaNodes);
   }
 
+  private function shouldUpdate(DailyEmail $email): bool {
+    if (!$email->isNew()) {
+      return FALSE;
+    }
+
+    if ($email->get('field_daily_email_cta')->getValue() !== []) {
+      return FALSE;
+    }
+
+    $body = $email->get('body')->value;
+    assert(is_string($body));
+
+    if (str_contains(haystack: $body, needle: 'P.S.')) {
+      return FALSE;
+    }
+
+    return TRUE;
+  }
+
 }