From addfe15e262d3b63814b47d30e5e8c776a39567c Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Sat, 21 Jun 2025 00:42:49 +0100 Subject: [PATCH] Fix phpstan errors --- modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php | 5 ++++- .../src/Repository/PresentationNodeRepository.php | 2 ++ .../src/Repository/PresentationRepositoryInterface.php | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php b/modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php index 770f76fb1..71d17a3a0 100644 --- a/modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php +++ b/modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php @@ -22,7 +22,10 @@ readonly final class AddRandomCtaToDailyEmail { return; } - if (str_contains(haystack: $email->get('body')->value, needle: 'P.S.')) { + $body = $email->get('body')->value; + assert(is_string($body)); + + if (str_contains(haystack: $body, needle: 'P.S.')) { return; } diff --git a/modules/opd_presentations/src/Repository/PresentationNodeRepository.php b/modules/opd_presentations/src/Repository/PresentationNodeRepository.php index d9340e21e..e935f4b4a 100644 --- a/modules/opd_presentations/src/Repository/PresentationNodeRepository.php +++ b/modules/opd_presentations/src/Repository/PresentationNodeRepository.php @@ -23,7 +23,9 @@ final class PresentationNodeRepository implements PresentationRepositoryInterfac $query->condition('status', NodeInterface::PUBLISHED); $nodeIds = $query->execute(); + assert(is_array($nodeIds)); + /** @var Presentation[] */ return $this->nodeStorage->loadMultiple($nodeIds); } diff --git a/modules/opd_presentations/src/Repository/PresentationRepositoryInterface.php b/modules/opd_presentations/src/Repository/PresentationRepositoryInterface.php index 4666317fb..baacd98c3 100644 --- a/modules/opd_presentations/src/Repository/PresentationRepositoryInterface.php +++ b/modules/opd_presentations/src/Repository/PresentationRepositoryInterface.php @@ -4,6 +4,8 @@ declare(strict_types=1); namespace Drupal\opd_presentations\Repository; +use Drupal\opd_presentations\Presentation; + interface PresentationRepositoryInterface { /**