opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues 1 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Don't add a CTA if an emails contains a P.S.

Browse source 
Don't automatically add a CTA to a daily email if the email body text
already contains a "P.S.".
This commit is contained in:
Oliver Davies 2025-06-21 00:34:47 +01:00
parent b7f13b4be5
commit 9abf64b504
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/opd_daily_emails/src/AddRandomCtaToDailyEmail.php
View file

@ -22,7 +22,9 @@ readonly final class AddRandomCtaToDailyEmail {
return;
}
// TODO: Don't add a CTA if the email already contains a "P.S.".
if (str_contains(haystack: $email->get('body')->value, needle: 'P.S.')) {
return;
}
$nodeStorage = $this->entityTypeManager->getStorage('node');
$query = $nodeStorage->getQuery();

13
modules/opd_daily_emails/tests/src/Functional/CallToActionTest.php
View file

@ -46,4 +46,17 @@ final class CallToActionTest extends ExistingSiteBase {
);
}
public function test_cta_in_body_prevents_automatically_adding_a_cta(): void {
$email = $this->createNode([
'body' => [
'format' => 'basic_html',
'value' => 'P.S. This email already contains a CTA.',
],
'field_daily_email_cta' => NULL,
'type' => 'daily_email',
]);
$this->assertEmpty($email->get('field_daily_email_cta'));
}
}