From 216fe30bf533379021478108a985cb3cb83cf596 Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Fri, 3 May 2024 14:55:43 +0100 Subject: [PATCH] Add custom assertion for the talk count --- .../OpdaviesTwigExtensionTest.php | 21 ++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tests/Opdavies/TwigExtension/OpdaviesTwigExtensionTest.php b/tests/Opdavies/TwigExtension/OpdaviesTwigExtensionTest.php index 0b23e8e63..42852d50a 100644 --- a/tests/Opdavies/TwigExtension/OpdaviesTwigExtensionTest.php +++ b/tests/Opdavies/TwigExtension/OpdaviesTwigExtensionTest.php @@ -24,7 +24,7 @@ class OpdaviesTwigExtensionTest extends TestCase ], ); - self::assertSame(0, $this->extension->getPastTalkCount([$talk])); + $this->assertTalkCount(expectedCount: 0, talks: [$talk]); } public function testSinglePastEvent(): void @@ -41,7 +41,7 @@ class OpdaviesTwigExtensionTest extends TestCase ], ); - self::assertSame(1, $this->extension->getPastTalkCount([$talkA, $talkB])); + $this->assertTalkCount(expectedCount: 1, talks: [$talkA, $talkB]); } public function testSingleTalkWithMultiplePastEvents(): void @@ -54,7 +54,7 @@ class OpdaviesTwigExtensionTest extends TestCase ], ); - self::assertSame(3, $this->extension->getPastTalkCount([$talk])); + $this->assertTalkCount(expectedCount: 3, talks: [$talk]); } public function testSingleTalkWithMultiplePastAndFutureEvents(): void @@ -69,7 +69,7 @@ class OpdaviesTwigExtensionTest extends TestCase ], ); - self::assertSame(3, $this->extension->getPastTalkCount([$talk])); + $this->assertTalkCount(expectedCount: 3, talks: [$talk]); } public function testMultiplePastEvents(): void @@ -87,7 +87,18 @@ class OpdaviesTwigExtensionTest extends TestCase ], ); - self::assertSame(2, $this->extension->getPastTalkCount([$talkA, $talkB])); + $this->assertTalkCount(expectedCount: 2, talks: [$talkA, $talkB]); + } + + /** + * Assert the extension uses the correct number of talks. + */ + private function assertTalkCount(int $expectedCount, array $talks): void + { + self::assertSame( + actual: $this->extension->getPastTalkCount($talks), + expected: $expectedCount, + ); } /**