opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues 1 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Refactor

Browse source
This commit is contained in:
Oliver Davies 2025-06-12 02:10:08 +01:00
parent 51299096c5
commit 202552cdfe
1 changed files with 9 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

32
modules/opd_podcast/src/Guests.php
View file

@ -4,12 +4,10 @@ declare(strict_types=1);
namespace Drupal\opd_podcast;
use Drupal\taxonomy\TermInterface;
/**
* @implements \IteratorAggregate<Guest>
*/
final class Guests implements \ArrayAccess, \Countable, \IteratorAggregate, \Stringable {
final class Guests implements \Countable, \IteratorAggregate, \Stringable {
/**
* @param Guest[] $guests
@ -25,31 +23,15 @@ final class Guests implements \ArrayAccess, \Countable, \IteratorAggregate, \Str
return new \ArrayIterator($this->guests);
}
public function offsetExists(mixed $offset): bool {
return isset($this->guests[$offset]);
}
public function offsetGet(mixed $offset): mixed {
return $this->guests[$offset];
}
public function offsetSet(mixed $offset, mixed $value): void {
$this->guests[$offset] = $value;
}
public function offsetUnset(mixed $offset): void {
unset($this->guests[$offset]);
}
public function __toString(): string {
// TODO: allow for more than two guests.
if (count($this->guests) === 2) {
assert($this->guests[1] instanceof Guest);
if ($this->count() === 2) {
assert($this->get(0) instanceof Guest);
return sprintf('%s %s %s', $this->guests[0]->getName(), t('and'), $this->guests[1]->getName());
return sprintf('%s %s %s', $this->get(0)->getName(), t('and'), $this->get(1)->getName());
}
return strval($this->guests[0]->getName());
return strval($this->get(0)->getName());
}
/**
@ -59,4 +41,8 @@ final class Guests implements \ArrayAccess, \Countable, \IteratorAggregate, \Str
return new self($guests);
}
private function get(int $offset): ?Guest {
return $this->guests[$offset];
}
}