opdavies/oliverdavies.uk
1
0
Fork 0
Code Issues 1 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Move daily emails into the blog page

Browse source
This commit is contained in:
Oliver Davies 2025-08-21 00:28:10 +01:00
parent be69398931
commit 1b8441608f
828 changed files with 9 additions and 196 deletions
Download patch file Download diff file Expand all files Collapse all files

21
source/_posts/2024-10-30.md Normal file
View file

@ -0,0 +1,21 @@
---
title: Code reviews are about the code, not code style
date: 2024-10-30
permalink: daily/2024/10/30/code-reviews-are-about-the-code-not-code-style
tags:
- software-development
cta: ~
snippet: |
If you do code reviews, they should be about reviewing the code itself and not about the style of the code.
---
If you do code reviews, they should be about reviewing the code and not about the style of the code.
There shouldn't be comments about whether tabs or spaces are used, how many spaces are on each line, where the braces are, or whether there should be semicolons.
A code style should be defined upfront and checking code against it can be done automatically with tools such as phpcs or Prettier.
You don't need to wait for a human to review the code style - automated tools can be run locally or in a CI pipeline and provide feedback much faster.
And if people aren't reviewing the code style, they can focus on reviewing the code itself.