From 1b6ab19dcd3bef5e4ba6958389e77d8c77bcd1f2 Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Tue, 5 Sep 2023 22:15:25 +0100 Subject: [PATCH] daily-email: add 2023-09-01 Non-blocking code reviews --- src/content/daily-email/2023-09-01.md | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 src/content/daily-email/2023-09-01.md diff --git a/src/content/daily-email/2023-09-01.md b/src/content/daily-email/2023-09-01.md new file mode 100644 index 00000000..8b4e13d9 --- /dev/null +++ b/src/content/daily-email/2023-09-01.md @@ -0,0 +1,28 @@ +--- +title: > + Non-blocking code reviews +pubDate: 2023-09-01 +permalink: > + archive/2023/09/01/non-blocking-code-reviews +tags: + - ci-pipelines + - code-review +--- + +If your team wants or needs to do code reviews, but you don't want it to slow down development, you could implement non-blocking code reviews. + +Instead of creating a topic branch for a feature or fix, creating a pull or merge request and waiting for it to be reviewed before merging, the commit is merged, and the code is reviewed afterwards. + +The ticket workflow could look like this: + +To Do -> Doing -> Merged -> Reviewed -> Tested -> Deployed + +Or: + +To Do -> Doing -> Merged -> Deployed -> Tested -> Reviewed + +The focus is getting the update to production, and the review is deferred. + +The same CI pipeline rules apply - it must be passing before the code can be deployed, so the same quality checks are run. + +With this approach, the code is still reviewed, either in the pull or merge request or by the commits on the mainline branch if doing trunk-based development. It's just done later.