Return the email nodes, not just the node IDs

modules/opd_daily_emails/src/Collection/DailyEmailCollection.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\opd_daily_emails\Collection;
+
+use Drupal\node\NodeInterface;
+
+final class DailyEmailCollection implements \Countable {
+
+  public function __construct(
+    private array $emails,
+  ) {
+  }
+
+  public function count(): int {
+    return count($this->emails);
+  }
+
+  public function first(): NodeInterface {
+    return array_values($this->emails)[0];
+  }
+
+}

modules/opd_daily_emails/src/Repository/DailyEmailNodeRepository.php

@@ -6,6 +6,7 @@ namespace Drupal\opd_daily_emails\Repository;
 
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\node\NodeInterface;
+use Drupal\opd_daily_emails\Collection\DailyEmailCollection;
 
 final class DailyEmailNodeRepository implements DailyEmailRepositoryInterface {
 
@@ -14,20 +15,21 @@ final class DailyEmailNodeRepository implements DailyEmailRepositoryInterface {
   ) {
   }
 
-  public function getAll(): array {
+  public function getAll(): DailyEmailCollection {
-    $query = $this->entityTypeManager
+    $nodeStorage = $this->entityTypeManager
-      ->getStorage('node')
+      ->getStorage('node');
-      ->getQuery();
+
+    $query = $nodeStorage->getQuery();
 
     $query->condition('status', NodeInterface::PUBLISHED);
     $query->condition('type', 'daily_email');
 
     $query->accessCheck(TRUE);
 
-    $result = $query->execute();
+    $nodeIds = $query->execute();
+    $nodes = $nodeStorage->loadMultiple($nodeIds);
 
-    // TODO: this returns a list of node IDs. Load and return the nodes.
+    return new DailyEmailCollection($nodes);
-    return $result;
   }
 
 }

modules/opd_daily_emails/src/Repository/DailyEmailRepositoryInterface.php

@@ -4,8 +4,10 @@ declare(strict_types=1);
 
 namespace Drupal\opd_daily_emails\Repository;
 
+use Drupal\opd_daily_emails\Collection\DailyEmailCollection;
+
 interface DailyEmailRepositoryInterface {
 
-  public function getAll(): array;
+  public function getAll(): DailyEmailCollection;
 
 }

modules/opd_daily_emails/tests/src/Kernel/Repository/DailyEmailNodeRepositoryTest.php

@@ -39,9 +39,16 @@ final class DailyEmailNodeRepositoryTest extends EntityKernelTestBase {
       expected: DailyEmailRepositoryInterface::class,
     );
 
+    $emails = $repository->getAll();
+
     $this->assertCount(
       expectedCount: 1,
-      haystack: $repository->getAll(),
+      haystack: $emails,
+    );
+
+    $this->assertSame(
+      expected: 'A published daily email',
+      actual: $emails->first()->label(),
     );
   }