opdavies/oliverdavies.uk-drupal-old
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Rename getAll to findAll, remove published argument

Browse source
This commit is contained in:
Oliver Davies 2021-02-10 02:35:10 +00:00
parent afc0a0e448
commit abe0f3d93b
3 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
web/modules/custom/talks/src/Repository/TalkRepository.php
View file

@ -21,16 +21,12 @@ final class TalkRepository {
/**
* @return Collection|Talk[]
*/
public function getAll(bool $publishedOnly = FALSE): Collection {
$properties = ['type' => 'talk'];
public function findAll(): Collection {
$talks = $this->nodeStorage->loadByProperties([
'type' => 'talk',
]);
if ($publishedOnly) {
$properties['status'] = TRUE;
}
return new Collection(
$this->nodeStorage->loadByProperties($properties)
);
return new Collection($talks);
}
/**

2
web/modules/custom/talks/src/Service/TalkDateUpdater.php
View file

@ -25,7 +25,7 @@ final class TalkDateUpdater {
}
public function __invoke(): void {
foreach ($this->talkRepository->getAll() as $talk) {
foreach ($this->talkRepository->findAll() as $talk) {
$this->updateNextEventDate($talk);
}
}

4
web/modules/custom/talks/tests/src/Kernel/Repository/TalkRepositoryTest.php
View file

@ -22,7 +22,7 @@ final class TalkRepositoryTest extends TalksTestBase {
$this->createTalk(['title' => 'Taking Flight with Tailwind CSS']);
$this->createTalk(['title' => 'Upgrading to Drupal 9']);
$talks = $this->talkRepository->getAll();
$talks = $this->talkRepository->findAll();
$this->assertCount(3, $talks);
$this->assertSame(
@ -57,7 +57,7 @@ final class TalkRepositoryTest extends TalksTestBase {
public function it_only_returns_talk_nodes(): void {
$this->createNode(['type' => 'page']);
$talks = $this->talkRepository->getAll();
$talks = $this->talkRepository->findAll();
$this->assertEmpty($talks);
}