From 87ee87f915529ccef26f915e3c5f2deb3f4f086f Mon Sep 17 00:00:00 2001
From: Oliver Davies <oliver@oliverdavies.uk>
Date: Fri, 1 Jan 2021 23:04:28 +0000
Subject: [PATCH] Fix blog tag re-ordering test

Add a NullPostPusher implementation and use it within the tag
re-ordering tests to stop an Exception being thrown because there's no
webhook URL.

References #332
---
 web/modules/custom/blog/opdavies_blog.services.yml  |  3 +++
 .../blog/src/Service/PostPusher/NullPostPusher.php  | 13 +++++++++++++
 .../blog_test/opdavies_blog_test.services.yml       |  3 +++
 .../blog/tests/src/Kernel/ReorderBlogTagsTest.php   |  4 +++-
 4 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 web/modules/custom/blog/src/Service/PostPusher/NullPostPusher.php
 create mode 100644 web/modules/custom/blog/tests/modules/blog_test/opdavies_blog_test.services.yml

diff --git a/web/modules/custom/blog/opdavies_blog.services.yml b/web/modules/custom/blog/opdavies_blog.services.yml
index 8dc9c65..85dc656 100644
--- a/web/modules/custom/blog/opdavies_blog.services.yml
+++ b/web/modules/custom/blog/opdavies_blog.services.yml
@@ -14,5 +14,8 @@ services:
   Drupal\opdavies_blog\Service\PostPusher\IftttPostPusher:
     autowire: true
 
+  Drupal\opdavies_blog\Service\PostPusher\NullPostPusher:
+    autowire: true
+
   Drupal\opdavies_blog\Service\PostPusher\PostPusher:
     alias: Drupal\opdavies_blog\Service\PostPusher\IftttPostPusher
diff --git a/web/modules/custom/blog/src/Service/PostPusher/NullPostPusher.php b/web/modules/custom/blog/src/Service/PostPusher/NullPostPusher.php
new file mode 100644
index 0000000..55cc133
--- /dev/null
+++ b/web/modules/custom/blog/src/Service/PostPusher/NullPostPusher.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\opdavies_blog\Service\PostPusher;
+
+use Drupal\opdavies_blog\Entity\Node\Post;
+
+final class NullPostPusher implements PostPusher {
+
+  public function push(Post $post): void {}
+
+}
diff --git a/web/modules/custom/blog/tests/modules/blog_test/opdavies_blog_test.services.yml b/web/modules/custom/blog/tests/modules/blog_test/opdavies_blog_test.services.yml
new file mode 100644
index 0000000..27bfd9c
--- /dev/null
+++ b/web/modules/custom/blog/tests/modules/blog_test/opdavies_blog_test.services.yml
@@ -0,0 +1,3 @@
+services:
+  Drupal\opdavies_blog\Service\PostPusher\PostPusher:
+    alias: Drupal\opdavies_blog\Service\PostPusher\NullPostPusher
diff --git a/web/modules/custom/blog/tests/src/Kernel/ReorderBlogTagsTest.php b/web/modules/custom/blog/tests/src/Kernel/ReorderBlogTagsTest.php
index 4fa3b48..4343d3d 100644
--- a/web/modules/custom/blog/tests/src/Kernel/ReorderBlogTagsTest.php
+++ b/web/modules/custom/blog/tests/src/Kernel/ReorderBlogTagsTest.php
@@ -30,8 +30,8 @@ final class ReorderBlogTagsTest extends EntityKernelTestBase {
     'core_event_dispatcher',
 
     // Custom.
-    'opdavies_blog_test',
     'opdavies_blog',
+    'opdavies_blog_test',
   ];
 
   /** @test */
@@ -67,6 +67,8 @@ final class ReorderBlogTagsTest extends EntityKernelTestBase {
       'opdavies_blog_test',
     ]);
 
+    $this->installSchema('node', ['node_access']);
+
     $this->installEntitySchema('taxonomy_vocabulary');
     $this->installEntitySchema('taxonomy_term');
   }