From 8591a0f8468071cc3ae08d710b6f13237ac95cde Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Thu, 17 Dec 2020 23:10:29 +0000 Subject: [PATCH] Remove strict types in tests, ensure classes are final --- .../custom/blog/tests/src/Kernel/Entity/Node/PostTest.php | 2 -- .../custom/talks/tests/src/Kernel/CountPreviousTalksTest.php | 4 +--- .../talks/tests/src/Kernel/EventsAreReorderedByDateTest.php | 2 -- .../custom/talks/tests/src/Kernel/TalksPageSortTest.php | 2 -- web/modules/custom/talks/tests/src/Kernel/TalksTestBase.php | 2 -- .../talks/tests/src/Kernel/UpdatesTalkCreatedDateTest.php | 2 -- 6 files changed, 1 insertion(+), 13 deletions(-) diff --git a/web/modules/custom/blog/tests/src/Kernel/Entity/Node/PostTest.php b/web/modules/custom/blog/tests/src/Kernel/Entity/Node/PostTest.php index b33a458..f9b22fb 100644 --- a/web/modules/custom/blog/tests/src/Kernel/Entity/Node/PostTest.php +++ b/web/modules/custom/blog/tests/src/Kernel/Entity/Node/PostTest.php @@ -2,8 +2,6 @@ // phpcs:disable Drupal.Commenting.DocComment, Drupal.NamingConventions.ValidFunctionName -declare(strict_types=1); - namespace Drupal\Tests\opdavies_blog\Kernel\Entity\Node; use Drupal\KernelTests\Core\Entity\EntityKernelTestBase; diff --git a/web/modules/custom/talks/tests/src/Kernel/CountPreviousTalksTest.php b/web/modules/custom/talks/tests/src/Kernel/CountPreviousTalksTest.php index cf97904..f146891 100644 --- a/web/modules/custom/talks/tests/src/Kernel/CountPreviousTalksTest.php +++ b/web/modules/custom/talks/tests/src/Kernel/CountPreviousTalksTest.php @@ -2,8 +2,6 @@ // phpcs:disable Drupal.Commenting.DocComment, Drupal.NamingConventions.ValidFunctionName -declare(strict_types=1); - namespace Drupal\Tests\opdavies_talks\Kernel; use Carbon\Carbon; @@ -11,7 +9,7 @@ use Drupal\node\NodeInterface; use Drupal\opdavies_talks\Service\TalkCounter; use PHPUnit\Framework\Assert; -class CountPreviousTalksTest extends TalksTestBase { +final class CountPreviousTalksTest extends TalksTestBase { private TalkCounter $talkCounter; diff --git a/web/modules/custom/talks/tests/src/Kernel/EventsAreReorderedByDateTest.php b/web/modules/custom/talks/tests/src/Kernel/EventsAreReorderedByDateTest.php index 7ba60c8..91f0236 100644 --- a/web/modules/custom/talks/tests/src/Kernel/EventsAreReorderedByDateTest.php +++ b/web/modules/custom/talks/tests/src/Kernel/EventsAreReorderedByDateTest.php @@ -1,7 +1,5 @@