opdavies/oliverdavies.uk-drupal-old
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Refactor existing tests

Browse source 
References #74
This commit is contained in:
Oliver Davies 2020-05-31 14:55:50 +01:00
parent 95a3187186
commit 45fda0fed1
2 changed files with 28 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
web/modules/custom/custom/tests/src/Kernel/TalksTestBase.php
View file

@ -32,16 +32,23 @@ abstract class TalksTestBase extends EntityKernelTestBase {
'custom_test', 'custom_test',
]; ];
protected function createEvent(string $eventDateToFormat): ParagraphInterface { protected function createEvent(array $overrides = []): ParagraphInterface {
/** @var \Drupal\paragraphs\ParagraphInterface $event */ $event = Paragraph::create(array_merge([
$event = Paragraph::create([
'field_date' => $eventDateToFormat,
'type' => 'event', 'type' => 'event',
]); ], $overrides));
return tap($event)->save(); return tap($event)->save();
} }
protected function createTalk(array $overrides = []): EntityInterface {
$talk = Node::create(array_merge([
'title' => 'Test Driven Drupal',
'type' => 'talk',
], $overrides));
return tap($talk)->save();
}
protected function setUp() { protected function setUp() {
parent::setUp(); parent::setUp();
@ -51,21 +58,4 @@ abstract class TalksTestBase extends EntityKernelTestBase {
$this->installConfig(['custom_test']); $this->installConfig(['custom_test']);
} }
protected function createTalk(?string $eventDateToFormat = NULL): EntityInterface {
if ($eventDateToFormat) {
$event = $this->createEvent($eventDateToFormat);
}
$talk = Node::create([
'title' => 'TDD - Test Driven Drupal',
'type' => 'talk',
]);
if (isset($event)) {
$talk->set('field_events', [$event]);
}
return tap($talk)->save();
}
} }

28
web/modules/custom/custom/tests/src/Kernel/UpdatesTalkCreatedDateTest.php
View file

@ -11,27 +11,31 @@ final class UpdatesTalkCreatedDateTest extends TalksTestBase {
public function testCreatingNode() { public function testCreatingNode() {
$eventDate = Carbon::today()->addWeek(); $eventDate = Carbon::today()->addWeek();
$eventDateToFormat = $eventDate->format(DateTimeItemInterface::DATE_STORAGE_FORMAT); $eventDateFormat = $eventDate->format(DateTimeItemInterface::DATE_STORAGE_FORMAT);
$eventDateToTimestamp = $eventDate->getTimestamp(); $eventDateTimestamp = $eventDate->getTimestamp();
$talk = $this->createTalk($eventDateToFormat); $talk = $this->createTalk([
'field_events' => [
$this->createEvent(['field_date' => $eventDateFormat]),
],
]);
$this->assertEqual($eventDateToTimestamp, $talk->get('created') $this->assertEqual($eventDateTimestamp, $talk->get('created')
->getString()); ->getString());
} }
public function testUpdatingNode() { public function testUpdatingNode() {
$talk = $this->createTalk();
$eventDate = Carbon::today()->addWeek(); $eventDate = Carbon::today()->addWeek();
$eventDateToFormat = $eventDate->format(DateTimeItemInterface::DATE_STORAGE_FORMAT); $eventDateFormat = $eventDate->format(DateTimeItemInterface::DATE_STORAGE_FORMAT);
$eventDateToTimestamp = $eventDate->getTimestamp(); $eventDateTimestamp = $eventDate->getTimestamp();
$event = $this->createEvent($eventDateToFormat); $talk = $this->createTalk([
$talk->set('field_events', [$event]); 'field_events' => [
$talk->save(); $this->createEvent(['field_date' => $eventDateFormat]),
],
]);
$this->assertEqual($eventDateToTimestamp, $talk->get('created') $this->assertEqual($eventDateTimestamp, $talk->get('created')
->getString()); ->getString());
} }