From caa3767246ff57a1ab53374bfb0737c820a183eb Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Wed, 1 May 2019 19:18:41 +0100 Subject: [PATCH] Use addOption() instead of setDefinition() --- CHANGELOG.md | 2 ++ src/Console/Command/GenerateCommand.php | 8 +++----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 82f128c..5f74c88 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Released 2019-xx-xx: +- No issue: remove `setDefinition()` and use `addOption()` in `GenerateCommand::configure()` + ## 2.3.0 Released 2019-05-01: diff --git a/src/Console/Command/GenerateCommand.php b/src/Console/Command/GenerateCommand.php index 02969d5..83fe957 100644 --- a/src/Console/Command/GenerateCommand.php +++ b/src/Console/Command/GenerateCommand.php @@ -22,12 +22,10 @@ class GenerateCommand extends Command { $this ->setName(self::NAME) - ->setDefinition([ - new InputOption('input-file', 'i', InputOption::VALUE_OPTIONAL, 'The name of the PHP file containing your filters.', 'filters.php'), - new InputOption('output-file', 'o', InputOption::VALUE_OPTIONAL, 'The name of the XML file to generate.'), - new InputOption('expanded', 'e', InputOption::VALUE_NONE, 'Whether to generate expanded XML.') - ]) ->setDescription('Generates XML for Gmail filters.') + ->addOption('input-file', 'i', InputOption::VALUE_OPTIONAL, 'The name of the PHP file containing your filters.', 'filters.php') + ->addOption('output-file', 'o', InputOption::VALUE_OPTIONAL, 'The name of the XML file to generate.') + ->addOption('expanded', 'e', InputOption::VALUE_NONE, 'Whether to generate expanded XML.') ; }