Add line breaks for better readability

This commit is contained in:
Oliver Davies 2018-01-04 23:22:23 +00:00
parent 34ae5d9bcd
commit 6ccf830d23
2 changed files with 9 additions and 16 deletions

View file

@ -31,9 +31,9 @@ class Builder
$xml = collect($this->filters)->map(function ($items) {
return $this->buildEntry($items);
})->implode('');
})->implode(PHP_EOL);
return $prefix . $xml . $suffix;
return collect([$prefix, $xml, $suffix])->implode(PHP_EOL);
}
/**

View file

@ -20,20 +20,13 @@ class BuilderTest extends TestCase
$result = new Builder([$filterA, $filterB]);
$expected = "<?xml version='1.0' encoding='UTF-8'?>";
$expected .= "<feed xmlns='http://www.w3.org/2005/Atom' xmlns:apps='http://schemas.google.com/apps/2006'>";
$expected .= '<entry>';
$expected .= "<apps:property name='from' value='foo@example.com|test@example.com'/>";
$expected .= "<apps:property name='label' value='Some label'/>";
$expected .= "<apps:property name='shouldArchive' value='true'/>";
$expected .= '</entry>';
$expected .= '<entry>';
$expected .= "<apps:property name='hasTheWord' value='from:bar@example.com'/>";
$expected .= "<apps:property name='shouldStar' value='true'/>";
$expected .= "<apps:property name='shouldAlwaysMarkAsImportant' value='true'/>";
$expected .= '</entry>';
$expected .= '</feed>';
$expected = <<<EOF
<?xml version='1.0' encoding='UTF-8'?><feed xmlns='http://www.w3.org/2005/Atom' xmlns:apps='http://schemas.google.com/apps/2006'>
<entry><apps:property name='from' value='foo@example.com|test@example.com'/><apps:property name='label' value='Some label'/><apps:property name='shouldArchive' value='true'/></entry>
<entry><apps:property name='hasTheWord' value='from:bar@example.com'/><apps:property name='shouldStar' value='true'/><apps:property name='shouldAlwaysMarkAsImportant' value='true'/></entry>
</feed>
EOF;
$this->assertEquals($expected, $result);
$this->assertEquals($expected, $result->__toString());
}
}