[Security] Bump symfony/cache from 4.2.1 to 4.3.5

Bumps [symfony/cache](https://github.com/symfony/cache) from 4.2.1 to 4.3.5. **This update includes security fixes.**
- [Release notes](https://github.com/symfony/cache/releases)
- [Changelog](https://github.com/symfony/cache/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/cache/compare/v4.2.1...v4.3.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

composer.json

@@ -2,13 +2,13 @@
     "type": "project",
     "license": "proprietary",
     "require": {
-        "php": "^7.1.3",
+        "php": "~7.1",
         "ext-ctype": "*",
         "ext-iconv": "*",
         "josephlavin/tap": "^1.0",
         "jublonet/codebird-php": "^3.1",
         "symfony/console": "4.2.*",
-        "symfony/dotenv": "4.2.*",
+        "symfony/dotenv": "4.3.*",
         "symfony/flex": "^1.1",
         "symfony/framework-bundle": "4.2.*",
         "symfony/orm-pack": "^1.0",
@@ -41,8 +41,7 @@
     },
     "scripts": {
         "auto-scripts": {
-            "cache:clear": "symfony-cmd",
-            "assets:install %PUBLIC_DIR%": "symfony-cmd"
+            "cache:clear": "symfony-cmd"
         },
         "post-install-cmd": [
             "@auto-scripts"

src/Command/FetchTweetsCommand.php

@@ -4,10 +4,10 @@ namespace App\Command;
 
 use App\Entity\Tweet;
 use App\Service\TweetFetcher;
-use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
 
 class FetchTweetsCommand extends Command
 {
@@ -18,32 +18,34 @@ class FetchTweetsCommand extends Command
      */
     private $tweetFetcher;
 
-    /**
-     * @var \Doctrine\ORM\EntityManagerInterface
-     */
-    private $entityManager;
-
-    public function __construct(TweetFetcher $tweetFetcher, EntityManagerInterface $entityManager)
+    public function __construct(TweetFetcher $tweetFetcher)
     {
         parent::__construct();
 
         $this->tweetFetcher = $tweetFetcher;
-        $this->entityManager = $entityManager;
     }
 
     protected function configure()
     {
         $this
-            ->setDescription('Add a short description for your command')
+            ->setDescription('Fetch and store any tweets to be retweeted')
         ;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $this->tweetFetcher->getTweets()->each(function (Tweet $tweet) {
-            $this->entityManager->persist($tweet);
-        });
+        $io = new SymfonyStyle($input, $output);
 
-        $this->entityManager->flush();
+        $io->table(
+          ['Tweet', 'Author', 'Created', 'ID'],
+          $this->tweetFetcher->getTweets()->map(function (Tweet $tweet) {
+              return [
+                  $tweet->getText(),
+                  $tweet->getAuthor(),
+                  $tweet->getCreated(),
+                  $tweet->getId(),
+              ];
+          })->all()
+        );
     }
 }

src/Command/RetweetTweetsCommand.php

@@ -2,15 +2,15 @@
 
 namespace App\Command;
 
-use App\Model\Tweet;
+use App\Entity\Tweet;
+use App\Repository\TweetRepository;
 use App\Service\Retweeter;
 use App\Service\TweetFetcher;
+use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Console\Style\SymfonyStyle;
 
 class RetweetTweetsCommand extends Command
 {
@@ -20,25 +20,48 @@ class RetweetTweetsCommand extends Command
 
     private $retweeter;
 
-    public function __construct(TweetFetcher $tweetFetcher, Retweeter $retweeter)
-    {
+    /**
+     * @var \App\Repository\TweetRepository
+     */
+    private $tweetRepository;
+
+    /**
+     * @var \Doctrine\ORM\EntityManagerInterface
+     */
+    private $entityManager;
+
+    public function __construct(
+        TweetFetcher $tweetFetcher,
+        TweetRepository $tweetRepository,
+        Retweeter $retweeter,
+        EntityManagerInterface $entityManager
+    ) {
         parent::__construct();
 
         $this->tweetFetcher = $tweetFetcher;
         $this->retweeter = $retweeter;
+        $this->tweetRepository = $tweetRepository;
+        $this->entityManager = $entityManager;
     }
 
     protected function configure()
     {
         $this
-            ->setDescription('Add a short description for your command')
+            ->setDescription('Retweet one or more stored tweets')
+            ->addOption('number', null, InputOption::VALUE_OPTIONAL, 'Specify how many tweets to retweet.', 1)
         ;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $this->tweetFetcher->getTweets()->each(function (Tweet $tweet) {
+        $this->tweetRepository->getUntweetedTweets($input->getOption('number'))->each(function (Tweet $tweet) {
             $this->retweeter->retweet($tweet);
+
+            $tweet->setRetweeted(time());
+
+            $this->entityManager->persist($tweet);
         });
+
+        $this->entityManager->flush();
     }
 }

src/Repository/TweetRepository.php

@@ -5,6 +5,7 @@ namespace App\Repository;
 use App\Entity\Tweet;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Symfony\Bridge\Doctrine\RegistryInterface;
+use Tightenco\Collect\Support\Collection;
 
 /**
  * @method Tweet|null find($id, $lockMode = null, $lockVersion = null)
@@ -29,22 +30,19 @@ class TweetRepository extends ServiceEntityRepository
 
         return collect($result)->first();
     }
-    // /**
-    //  * @return Tweet[] Returns an array of Tweet objects
-    //  */
-    /*
-    public function findByExampleField($value)
+
+
+    public function getUntweetedTweets(int $limit): Collection
     {
-        return $this->createQueryBuilder('t')
-            ->andWhere('t.exampleField = :val')
-            ->setParameter('val', $value)
-            ->orderBy('t.id', 'ASC')
-            ->setMaxResults(10)
-            ->getQuery()
-            ->getResult()
-        ;
+        return collect(
+            $this->createQueryBuilder('t')
+                ->where('t.retweeted is NULL')
+                ->orderBy('t.created', 'asc')
+                ->setMaxResults($limit)
+                ->getQuery()
+                ->getResult()
+        );
     }
-    */
 
     /*
     public function findOneBySomeField($value): ?Tweet

src/Service/Retweeter.php

@@ -2,7 +2,7 @@
 
 namespace App\Service;
 
-use App\Model\Tweet;
+use App\Entity\Tweet;
 
 class Retweeter
 {

src/Service/TweetFetcher.php

@@ -4,6 +4,7 @@ namespace App\Service;
 
 use App\Entity\Tweet;
 use App\Repository\TweetRepository;
+use Doctrine\ORM\EntityManagerInterface;
 use Tightenco\Collect\Support\Collection;
 
 class TweetFetcher
@@ -30,30 +31,36 @@ class TweetFetcher
     ];
 
     /**
-     * @var \App\Repository\TweetRepository
+     * @var \Doctrine\ORM\EntityManagerInterface
+     */
+    private $entityManager;
+
+    /**
+     * @var \App\Service\TweetRepository
      */
     private $tweetRepository;
 
-    public function __construct(Codebird $codebird, TweetRepository $tweetRepository)
+    public function __construct(Codebird $codebird, EntityManagerInterface $entityManager, TweetRepository $tweetRepository)
     {
         $this->codebird = $codebird;
+        $this->entityManager = $entityManager;
         $this->tweetRepository = $tweetRepository;
     }
 
     public function getTweets(): Collection
     {
-        $latestTweet = $this->tweetRepository->findNewestTweet();
+        $params = ['q' => collect($this->params()->all())->implode(' AND ')];
+        if ($newestTweet = $this->tweetRepository->findNewestTweet()) {
+            $params['since_id'] = $newestTweet->getId();
+        }
 
-        $response = collect($this->codebird->get()->search_tweets([
-            'q' => collect($this->params()->all())->implode(' AND '),
-             'since_id' => $latestTweet ? $latestTweet->getId() : null,
-        ]));
+        $response = collect($this->codebird->get()->search_tweets($params));
 
         if ($response->get('httpstatus') != 200) {
             dump($response);
         }
 
-        return collect($response->get('statuses'))
+        $tweets = collect($response->get('statuses'))
             ->map(function (\stdClass $status) {
                 return tap(new Tweet(), function (Tweet $tweet) use ($status) {
                     $tweet->setId($status->id);
@@ -64,6 +71,10 @@ class TweetFetcher
                     $this->entityManager->persist($tweet);
                 });
             })->reverse();
+
+        $this->entityManager->flush();
+
+        return $tweets;
     }
 
     private function params(): Collection

symfony.lock

@@ -188,6 +188,9 @@
             "ref": "5374e24d508ba8fd6ba9eb15170255fdb778316a"
         }
     },
+    "symfony/stopwatch": {
+        "version": "v4.2.2"
+    },
     "symfony/var-dumper": {
         "version": "v4.2.2"
     },